Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Fallback for Blocked demdex.net Requests #1215

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Implement Fallback for Blocked demdex.net Requests #1215

wants to merge 8 commits into from
+238 −81

Conversation

shammowla
Copy link
Collaborator

Summary

Added fallback mechanism to use configured edge domain when demdex.net requests fail. This improves reliability when users have ad blockers or network restrictions that block third-party endpoints.
Changes

Added detection of demdex.net failures in network requests
Implemented fallback to edge domain
Added test coverage

Testing

Verified behavior with:

New functional test suite (demdexFallback.js)

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

jonsnyder
jonsnyder approved these changes Nov 19, 2024
View reviewed changes
src/core/edgeNetwork/injectSendEdgeNetworkRequest.js
// Notice we're calling the onResponse lifecycle method even if there are errors
// inside the response body. This is because the full request didn't actually fail--
// only portions of it that are considered non-fatal (a specific, non-critical
// Konductor plugin, for example).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove these comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterworks carterworks carterworks approved these changes

@jonsnyder jonsnyder jonsnyder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shammowla @jonsnyder @carterworks